c - Values always do not tally -


i'm relatively new c programming , trying code program reads in user's marks , assign grade mark inputted. have used getline() function acquire user input. below code.

# include <stdio.h> # include <stdlib.h> # include <string.h> # include <ctype.h>  int getmark(); void display(char grade); char convert(int mark);  int getmark() {     {         int marks;         char * buffer;         char characters;         size_t bufsize = 16;          buffer = (char *)malloc(bufsize * sizeof(char));         if( buffer == null) {         perror("unable allocate buffer");         exit(1);         }          printf("enter score (0 - 100)\nor press enter key quit ==> ");         characters = getline(&buffer, & bufsize, stdin);         int i;         long check;         (i = 0; < sizeof(buffer); i++) {             if (buffer[i] == '\n' && != 0) {                 buffer[i] = '\0';             }              if (isdigit(buffer[i]) || buffer[i] == '\0') {                 check++;             }         }          if (buffer[0] == '\n') {             return -1;         } else if (check == strlen(buffer) - 1) {             marks = atoi(buffer);         } else {             printf("please enter integer.\n");             continue;         }          if (marks >= 0 && marks <= 100) {             return marks;         } else {             printf("sorry, marks can between 0 100.\n");             continue;         }      } while (1); }  void display(char grade) {     printf("the grade input score %c \n", grade); }  char convert(int mark) {     mark /= 10;     char grade;      switch(mark) {         case 0:         case 1:         case 2:         case 3:         grade = 'f';         break;         case 4:         grade = 'e';         break;         case 5:         grade = 'd';         break;         case 6:         grade = 'c';         break;         case 7:         grade = 'b';         break;         case 8:         case 9:         case 10:         grade = 'a';     }      return grade; }  int main() {     int marks;     (;;) {         marks = getmark();         if (marks == -1) {             break;         }         display(convert(marks));     }      return 0; }

when press enter, program exits, expected. however, when integer entered, example 12, output please enter integer.

can me on this? thanks!

char * buffer; ... (i = 0; < sizeof(buffer); i++) {     if (buffer[i] == '\n' && != 0) {

sizeof(buffer) returns size of pointer char (4 or 8 bytes depending on architecture), not length of string, in consequence, reading outside of bounds of array when 12 entered.

change strlen() or better yet, use result of getline:

on success, getline() , getdelim() return number of characters read, including delimiter character, not including terminating null byte ('\0').


Comments

Post a Comment

Popular posts from this blog

asynchronous - C# WinSCP .NET assembly: How to upload multiple files asynchronously -

i using winscp .net assembly uploading files. want upload multiple files asynchronous way. have created method works single upload. public class uploadingdata { private sessionoptions _sessionoptions; private session _session; //connection etc private void onconnected() { foreach (var fileinfo in localfileslist) { var task = task.factory.startnew(() => uploadfilesasync(fileinfo)); } } private async task uploadfilesasync(string file) { string remotefilepath = _session.translatelocalpathtoremote(file, @"/", "/test_data_upload"); var uploading = _session.putfiles(file, remotefilepath, false); //when done await task.run(() => thread.sleep(1000)); } } please suggest me correct way. thanks you can use backgroundworker class this: string[] images = new string[50]; foreach (var path in images) { backgroundworker
Read more

aws api gateway - SerializationException in posting new Records via Dynamodb Proxy Service in API -

i getting "__type": "com.amazon.coral.service#serializationexception" as reply in postman & in test console in api gateway trying post record directly dynamodb using api proxy services.. referring aws article - https://aws.amazon.com/blogs/compute/using-amazon-api-gateway-as-a-proxy-for-dynamodb/ here's mapping { "tablename": "tablenamegoeshere", "item": { "id" : "$context.requestid" "eventname" : "$input.path('$.eventname')", "timestamp" : $input.path('$.timestamp'), "answers": "$util.parsejson($input.path('$.answers'))" } } update: did asked ... , worked if try add array of json objects gives me above same error - here's trying now. please - couldnt find on google well #set($inputroot = $input.path('$')) { "tablename": "answer", "item": {
Read more

asp.net - Problems sending emails from forum -

i have been redesigning site has message board, has been written guy looked after site. it has few problems , written in .asp , uses .mdb files database. you can see whole thing here . feel free post if helps, test thing have set using original files , new database. the basic problem when posts message, supposed email sent them, have posted it. when replies, originator supposed message, replier has been posted. i’d have thought @ point in process there should script/file in postmessage.asp? the postmessage.asp page below. <% option explicit %> <!-- #include virtual="common/adovbs.inc" --> <html> <head> <meta http-equiv="content-type" content="text/html; charset=windows-1252"> <meta name="generator" content="microsoft frontpage 4.0"> <meta name="progid" content="frontpage.editor.document"> <title>new page 2</title> <base target="_self"
Read more